GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: add contribution note for nodejs/node#65342 by soulee-dev · Pull Request #3 · ossca-node/board

Conversation

@soulee-dev

@soulee-dev soulee-dev commented Aug 22, 2026

Copy link
Copy Markdown

nodejs/node#65342 기여 노트를 추가합니다.

  • PR: ffi: validate the value passed to the float setters nodejs/node#65342 (ffi: validate the value passed to the float setters, 2026-08-19 병합)
  • Issue: ffi: setFloat32()/setFloat64() coerce their value and discard a pending exception nodejs/node#65341

src/ffi/data.cc의 float setter가 ToNumber()로 값을 강제 변환하던 것을 IsNumber() 검증으로 바꾼 작업에 대한 기록입니다.

npm test, npm run validate 통과를 확인했습니다.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@soulee-dev
docs: add contribution note for nodejs/node#65342
50010cd
daeyeon
daeyeon approved these changes Aug 22, 2026
View reviewed changes

@daeyeon daeyeon left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daeyeon
daeyeon merged commit 5f54a06 into ossca-node:main Aug 22, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daeyeon daeyeon daeyeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@soulee-dev @daeyeon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.