GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve package names inside npm prerelease versions by codewithfourtix · Pull Request #236 · package-url/packageurl-python

Conversation

@codewithfourtix

@codewithfourtix codewithfourtix commented Sep 5, 2026

Copy link
Copy Markdown

Parsing foo-1.0.0-foo.1.tgz currently drops both occurrences of foo, changing the version to 1.0.0-.1. Remove only the filename prefix so the prerelease version stays intact.

Adds regression coverage for scoped and unscoped npm downloads.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codewithfourtix
Preserve package names inside npm prerelease versions
7a3c247 
Signed-off-by: Ali Zulfiqar <[email protected]>
Copilot AI lite review requested due to automatic review settings September 5, 2026 17:02
Copilot started reviewing on behalf of codewithfourtix September 5, 2026 17:02
View session
Copilot AI reviewed Sep 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small, targeted, and the added regression test directly covers the reported parsing bug for both scoped and unscoped npm tarball URLs.

Pull request overview

Fixes npm download URL parsing so that prerelease versions containing the package name (e.g., foo-1.0.0-foo.1.tgz) keep the full prerelease string instead of incorrectly removing embedded name occurrences.

Changes:

  • Update npm tarball version extraction to remove only the leading filename prefix (not all occurrences).
  • Add regression tests covering both unscoped and scoped npm download URLs for this prerelease pattern.
File summaries
File Description
src/packageurl/contrib/url2purl.py Switches version derivation from global replace() to prefix-only removal to preserve prerelease content.
tests/contrib/test_url2purl.py Adds a regression test ensuring scoped/unscoped npm tarball URLs keep -foo.1 in the parsed version.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@codewithfourtix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.