GeezerVison

Also, this repository doesn't seem to have issues enabled. It would be good to turn that on as well?

Any progress on getting this merged? I don't see anything that should cause issue.

I'm afraid I don't have access to this repo to merge it. @alejandrogallo Any chance you can find some time to give it a look and merge it? 😁

EDIT: As far as I can tell the tests still pass (locally), but it's probably a good idea to re-run the CI anyway before merging.

EDIT2: Enabled support for testing on Python 3.13 as well! 😁

Trying to use this, I notice I needed to pass --ignore=docs to pytest, otherwise, it tries to collect from there as well and fails with

ImportError while importing test module '/home/gesh/aur/1+mine/python/python-doi/src/python-doi/docs/conf.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
docs/conf.py:130: in <module>
    from sphinx.ext.autodoc import (
E   ImportError: cannot import name 'InstanceAttributeDocumenter' from 'sphinx.ext.autodoc' (/usr/lib/python3.13/site-packages/sphinx/ext/autodoc/__init__.py)

Although the Makefile masks this by passing the relevant source directories to pytest directly, it'd be nice for python -m pytest to do the Right Thing™.

Anything left to get this merged @alejandrogallo ?

... Actually, it turns out that on my system, this PR suffices to get the tests to pass, with no other trickery needed. I don't know what happened in the last two months to make my bug no longer reproduce, but it seems #3 can be closed without merging it (or merged if we want that redundancy, though we'd probably want to drop the commit introducing rerunfailures if it's that unnecessary). I'll rebase it on top of this PR to make it easier to merge, presuming we're merging this one in in any case.

Ah, I see what happened -- 844fdfd fixed the urls the tests point to, making the tests no longer break

Trying to use this, I notice I needed to pass --ignore=docs to pytest, otherwise, it tries to collect from there as well and fails with

Just looked at docs/conf.py and it looks like it really needs a cleanup. I'll get to that after this PR gets in.

Ah, I see what happened -- 844fdfd fixed the urls the tests point to, making the tests no longer break

I think it's ok to change these because they're just checking that the DOI parsing works as expected. However, we might want to add some more tests to check that we manage to follow redirects properly and whatnot. Maybe a follow-up to #3 could go in that direction?

They're just checking that the DOI parsing works as expected

Yeah, I see it's just checking the https://doi.org/api/handles/ endpoint works as expected. I am trying to investigate getting the redirect code to work for robustness' sake, but OTOH given the 403's the redirected URLs are giving, I'm suspecting some of these sites aren't very scraper-friendly, and so are likely to be difficult to support.

Closed in favor of #3.