GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adjust logging lock handling for Python 3.13 by cjwatson · Pull Request #15 · pasteorg/pastescript

Conversation

@cjwatson

@cjwatson cjwatson commented Dec 8, 2024

Copy link
Copy Markdown
Contributor

python/cpython#109462 removed logging._acquireLock. Fortunately, python/cpython#3385 simplified lock creation so that with logging._lock: is sufficient; that PR made it into Python 3.7, which is already pastescript's minimum Python requirement.

(I know about pastescript being on life support; but it still seems to be used by some of the OpenStack packages in Debian, so from a Debian point of view I guess we're still stuck with it for now.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cjwatson added 2 commits December 8, 2024 15:10
@cjwatson
Adjust logging lock handling for Python 3.13
4f98831 
python/cpython#109462 removed
`logging._acquireLock`.  Fortunately,
python/cpython#3385 simplified lock creation so
that `with logging._lock:` is sufficient; that PR made it into Python
3.7, which is already pastescript's minimum Python requirement.
@cjwatson
Document Python 3.13 support
ae87d35
@cdent

cdent commented Jan 14, 2025

Copy link
Copy Markdown
Collaborator

Thanks for this, forgot to come back to it in the end of year chaos. Will merge it after making some fixes to the GitHub workflows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cdent
Merge branch 'master' into py313-logging-lock
9103d20
@cdent
cdent merged commit b4490a7 into pasteorg:master Jan 22, 2025
@cjwatson
cjwatson deleted the py313-logging-lock branch January 22, 2025 16:16
@jjhelmus jjhelmus mentioned this pull request Feb 11, 2025
Replace _logger_lock with logging._lock conda/conda#14584
Merged
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cjwatson @cdent
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.