GeezerVison is showing github.com — Remove errorprone and proguard optimized version to be able to build … · patrickfav/bytes-java@8e39cc7
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: .github/workflows/build_deploy.yml +5-5Lines changed: 5 additions & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -33,11 +33,11 @@ jobs: |
33 | 33 | path: ~/.m2 |
34 | 34 | key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} |
35 | 35 | restore-keys: ${{ runner.os }}-m2 |
36 | | - - name: Set up JDK 8 |
| 36 | + - name: Set up JDK 11 |
37 | 37 | uses: actions/setup-java@v3 |
38 | 38 | with: |
39 | | - java-version: '8' |
40 | | - distribution: 'adopt' |
| 39 | + java-version: '11' |
| 40 | + distribution: 'temurin' |
41 | 41 | - name: Build with Maven |
42 | 42 | run: ./mvnw -B clean verify checkstyle:checkstyle jacoco:report -DcommonConfig.jarSign.skip=true |
43 | 43 | - name: Analyze with SonaQube |
|
68 | 68 | - name: Set up Maven Central Repository |
69 | 69 | uses: actions/setup-java@v3 |
70 | 70 | with: |
71 | | - java-version: '8' |
72 | | - distribution: 'adopt' |
| 71 | + java-version: '11' |
| 72 | + distribution: 'temurin' |
73 | 73 | server-id: ossrh # Value of the distributionManagement/repository/id field of the pom.xml |
74 | 74 | server-username: MAVEN_USERNAME # env variable for username in deploy |
75 | 75 | server-password: MAVEN_PASSWORD # env variable for token in deploy |
|
Collapse file
Copy file name to clipboard +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
|
1 | | --DcommonConfig.compiler.profile=jdk7_w_errorprone |
| 1 | +-DcommonConfig.compiler.profile=jdk7 |
Collapse file
Copy file name to clipboardExpand all lines: README.md +2-2Lines changed: 2 additions & 2 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -700,8 +700,8 @@ the plugin versions as well as providing the checkstyle config rules. Specifical |
700 | 700 |
|
701 | 701 | ## Tech Stack |
702 | 702 |
|
703 | | -* Java 7 (+ [errorprone](https://github.com/google/error-prone) static analyzer) |
704 | | -* Maven |
| 703 | +* Java 7 Source, JDK 11 required to build (not yet JDK17 compatible) |
| 704 | +* Maven 3 |
705 | 705 |
|
706 | 706 | # Credits |
707 | 707 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: pom.xml +3-7Lines changed: 3 additions & 7 deletions | Original file line number | Diff line number | Diff line change |
|---|
|
7 | 7 | <parent> |
8 | 8 | <groupId>at.favre.lib</groupId> |
9 | 9 | <artifactId>common-parent</artifactId> |
10 | | - <version>18</version> |
| 10 | + <version>18.1</version> |
11 | 11 | </parent> |
12 | 12 |
|
13 | 13 | <artifactId>bytes</artifactId> |
|
23 | 23 | <inceptionYear>2017</inceptionYear> |
24 | 24 |
|
25 | 25 | <properties> |
26 | | - <commonConfig.jarSign.skip>false</commonConfig.jarSign.skip> |
| 26 | + <commonConfig.jarSign.skip>true</commonConfig.jarSign.skip> |
27 | 27 | <!-- SonarQube Config --> |
28 | 28 | <sonar.organization>patrickfav</sonar.organization> |
29 | 29 | <sonar.host.url>https://sonarcloud.io</sonar.host.url> |
|
41 | 41 | <plugin> |
42 | 42 | <groupId>org.apache.felix</groupId> |
43 | 43 | <artifactId>maven-bundle-plugin</artifactId> |
44 | | - <version>4.2.0</version> |
| 44 | + <version>5.1.8</version> |
45 | 45 | <extensions>true</extensions> |
46 | 46 | </plugin> |
47 | 47 | <plugin> |
|
71 | 71 | <groupId>org.jacoco</groupId> |
72 | 72 | <artifactId>jacoco-maven-plugin</artifactId> |
73 | 73 | </plugin> |
74 | | - <plugin> |
75 | | - <groupId>com.github.wvengen</groupId> |
76 | | - <artifactId>proguard-maven-plugin</artifactId> |
77 | | - </plugin> |
78 | 74 | <plugin> |
79 | 75 | <groupId>org.apache.maven.plugins</groupId> |
80 | 76 | <artifactId>maven-jarsigner-plugin</artifactId> |
|