GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add toIndex versions for indexOf() by hlyakhovich · Pull Request #48 · patrickfav/bytes-java

Conversation

@hlyakhovich

@hlyakhovich hlyakhovich commented Sep 3, 2022

Copy link
Copy Markdown
Contributor

Hi Patrick,
I've had a number of occasions when I found myself in need of a toIndex version of indexOf. I happen to know particular windows in my byte arrays where the value is supposed to be.

I'm leveraging existing functionality in indexOf, just passing a toIndex instead of length().

What do you think? Could this go into 1.5.1?

Regards,
Herman.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hlyakhovich
Add toIndex versions for indexOf()
966feae
@patrickfav
patrickfav merged commit 21f372f into patrickfav:master Sep 3, 2022
@patrickfav

patrickfav commented Sep 3, 2022

Copy link
Copy Markdown
Owner

Thanks for the PR! Will try to release ASAP!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hlyakhovich
hlyakhovich deleted the indexOf-toIndex branch September 6, 2022 11:22
@hlyakhovich

hlyakhovich commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

@patrickfav Any news on the release? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@patrickfav

patrickfav commented Sep 24, 2022

Copy link
Copy Markdown
Owner

Hopefully this weekend, need find time to adapt jcenter releasing to maven central releasing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hlyakhovich

hlyakhovich commented Sep 24, 2022

Copy link
Copy Markdown
Contributor Author

@patrickfav No rush, just keeping in touch. Thanks for the response 👌🏻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hlyakhovich

hlyakhovich commented Nov 19, 2022

Copy link
Copy Markdown
Contributor Author

@patrickfav friendly ping
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@patrickfav

patrickfav commented Feb 11, 2023

Copy link
Copy Markdown
Owner

Sorry took me way longer, needed to migrate various tools, but here it is: https://github.com/patrickfav/bytes-java/releases/tag/v1.6.0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hlyakhovich

hlyakhovich commented Feb 15, 2023

Copy link
Copy Markdown
Contributor Author

@patrickfav Thanks for the update!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hlyakhovich @patrickfav
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.