GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix HalfVector equality for signed zero by chaduo · Pull Request #164 · pgvector/pgvector-python

Conversation

@chaduo

@chaduo chaduo commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

HalfVector compares its uint16 storage rather than its numeric values, so vectors containing +0.0 and -0.0 compare unequal. Small positive and negative values that both round to zero expose the same issue. Vector and HalfVector in v0.4.2 use numeric equality.

Compare the decoded values instead. Keep the existing type check and preserve the stored sign bits, text serialization, and binary serialization. The regression tests cover direct construction, float16 underflow, text decoding, and binary decoding.

Validation: the five new cases failed on the unchanged implementation. The focused HalfVector, Vector, SparseVector, and Bit suites pass (60 passed, 8 skipped because SciPy is not installed). No PostgreSQL integration suite was run.

Prepared with assistance from OpenAI Codex. No independent human review is implied.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chaduo
Fix HalfVector equality for signed zero
02c8ea2
Copilot AI balanced review requested due to automatic review settings October 13, 2026 12:51
Copilot AI reviewed Oct 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ankane ankane closed this in 8cef6e4 Oct 13, 2026
@ankane

ankane commented Oct 13, 2026

Copy link
Copy Markdown
Member

Thanks @chaduo, merged a version of this in the commit above.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@chaduo @ankane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.