GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reject negative lengths in Bit.from_binary by beyondsundial · Pull Request #173 · pgvector/pgvector-python

Conversation

@beyondsundial

@beyondsundial beyondsundial commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Reject a negative bit length before constructing a Bit from binary data. With an empty payload, lengths -1 through -7 currently pass the byte-count check because (length + 7) // 8 is zero.

Add negative-length regression cases and round-trip controls at lengths 0, 1, 7, 8 and 9.

Validation: 75 Bit/vector/half-vector/sparse-vector tests passed; mypy for the changed files and git diff --check passed. Three new negative-length cases fail on the unchanged upstream baseline. PostgreSQL/driver integration tests and the full CI matrix were not run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@beyondsundial
Reject negative lengths in Bit.from_binary
0d23b07
@ankane ankane closed this in a755137 Oct 27, 2026
@ankane

ankane commented Oct 27, 2026

Copy link
Copy Markdown
Member

Thanks @beyondsundial, merged a version of this in the commit above.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@beyondsundial @ankane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.