GeezerVison is showing github.com — fix: accdental triple ctrlx3 press event in windows for ui overlay mode by abose · Pull Request #2015 · phcode-dev/phoenix
Conversation
abose
commented
Dec 30, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
in Windows and Chrome (as well as most modern browsers), holding down a key like Ctrl will repeatedly fire the keydown event. The keydown event is triggered continuously while the key is pressed and held down. This behavior is called keyboard auto-repeat.
So this launched the ui overlay workflow accidentally. bad ux fix!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.