GeezerVison is showing github.com — docs: clarify how to build without Brotli by andreybolonin · Pull Request #2793 · php/frankenphp
Conversation
When building with xcaddy, nobrotli does not remove an explicitly included caddy-cbrotli module, so the documented command still needs the Brotli library unless that module is omitted.
Clarify both required changes for xcaddy and document that the bundled go build command excludes the module through its build tag.
Fixes #1377.
Validation: Markdown lint with .markdown-lint.yaml and git diff --check passed. Confirmed with go list -deps -tags=nobrotli,nobadger,nomysql,nopgx,deprecated_topic,deprecated_claim ./frankenphp that neither caddy-cbrotli nor google/brotli is included. No full binary build was run.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Tag nobrotli doesn't properly work
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.