GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — sapi/phpdbg: restore the DEFAULT_SLASH check on the module path by darkdi · Pull Request #23583 · php/php-src

Conversation

@darkdi

@darkdi darkdi commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Before GH-21578 this guard read strchr(*path, '/') || strchr(*path, DEFAULT_SLASH). The rewrite onto memchr() kept the first half and copied it into the second, so both now look for '/', and the DEFAULT_SLASH half is gone. On Windows that means ext C:\path\php_foo.dll is not treated as a path at all, extension_dir gets glued in front of it and the load fails. ext/standard/dl.c still has the pair intact, which is what the phpdbg code was written from. Only master carries this, 8.4 and 8.5 still have the strchr version, and I have not touched the NEWS file since nothing released is affected.

Disclosure per CONTRIBUTING: the paragraph above was drafted with an LLM (Claude Code). The finding came from a static check of my own and I read the code and the history by hand.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Rant @claude Rant
sapi/phpdbg: restore the DEFAULT_SLASH check on the module path
afd8c66 
The move to memchr() in phpGH-21578 left both halves of the condition looking
for '/', so on Windows a path given with backslashes is not recognised as a
path and extension_dir gets prepended to it.

Co-Authored-By: Claude Opus 5 <[email protected]>
@github-actions github-actions Bot added the SAPI: phpdbg label Sep 5, 2026
@Girgias
Girgias merged commit 1d82b6f into php:master Sep 6, 2026
18 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@Girgias

Girgias commented Sep 6, 2026

Copy link
Copy Markdown
Member

Thank you, good find :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

SAPI: phpdbg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@darkdi @Girgias
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.