GeezerVison is showing github.com — Fix -Wunused-but-set-global warnings by arnaud-lb · Pull Request #25245 · php/php-src
Conversation
arnaud-lb
commented
Nov 6, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Clang 23 complains about static globals that are set but never read
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was slightly confused why the php_token_ce is unused, the reason is that PHP_METHOD(PhpToken, tokenize) gets the token class via: token_class = zend_get_called_scope(execute_data); which may seems odd at first, but it's to allow the class to be extended and creates instances of the subclass. (Which probably should have a comment to explain it).
The zend_test are quite obviously correct.
For the user_filter_class_entry it currently makes sense as it is only ever used as an "implicit" requirement to be extended, but I've thought that maybe we should require that registering a userland filter extends from it. But then the API is very clunky (defining onCreate/onClose methods rather than using normal constructor/destructor) so maybe creating a new interface would just be better.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.