GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix -Wunused-but-set-global warnings by arnaud-lb · Pull Request #25245 · php/php-src

Conversation

@arnaud-lb

@arnaud-lb arnaud-lb commented Nov 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Clang 23 complains about static globals that are set but never read

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@arnaud-lb
Fix -Wunused-but-set-global warnings
74c8148
@github-actions github-actions Bot added Extension: opcache Extension: standard Extension: tokenizer Extension: zend_test labels Nov 6, 2026
Girgias
Girgias approved these changes Nov 6, 2026
View reviewed changes

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was slightly confused why the php_token_ce is unused, the reason is that PHP_METHOD(PhpToken, tokenize) gets the token class via: token_class = zend_get_called_scope(execute_data); which may seems odd at first, but it's to allow the class to be extended and creates instances of the subclass. (Which probably should have a comment to explain it).

The zend_test are quite obviously correct.

For the user_filter_class_entry it currently makes sense as it is only ever used as an "implicit" requirement to be extended, but I've thought that maybe we should require that registering a userland filter extends from it. But then the API is very clunky (defining onCreate/onClose methods rather than using normal constructor/destructor) so maybe creating a new interface would just be better.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread main/rfc1867.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@arnaud-lb
Review
26c35b4
@arnaud-lb
arnaud-lb marked this pull request as ready for review November 11, 2026 16:21
@arnaud-lb
arnaud-lb requested review from bukka and dstogov as code owners November 11, 2026 16:21
@arnaud-lb
arnaud-lb merged commit 7b29976 into php:master Nov 11, 2026
18 checks passed

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 11, 2026
Fix -Wunused-but-set-global warning #25395
Closed
Disable -Wunused-but-set-global #25396
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes
@bukka bukka Awaiting requested review from bukka bukka is a code owner
@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Extension: opcache Extension: standard Extension: tokenizer Extension: zend_test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@arnaud-lb @Girgias
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.