GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Include property hooks in phpdbg opcode listings by crystarm · Pull Request #25366 · php/php-src

Conversation

@crystarm

@crystarm crystarm commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Fixes #25338.

phpdbg's opcode listing only iterated the class function table, so property hooks were omitted. Targeted hook selectors also did not work because the selector parser discarded the hook suffix and lowercased the case-sensitive property name.

This change:

  • includes declared property hooks in class opcode listings;
  • adds hooks to the method count and name list;
  • supports -p=Class::$property::get/set;
  • preserves property-name case while keeping function and method lookup
    case-insensitive;
  • avoids duplicate trait-cloned hook op arrays;
  • adds PHPT coverage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@github-actions github-actions Bot added the SAPI: phpdbg label Nov 10, 2026
@bwoebi

bwoebi commented Nov 10, 2026

Copy link
Copy Markdown
Member

This should probably be based on top of PHP 8.4.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@crystarm
Fix phpGH-25338: Include property hooks in phpdbg opcode listings
fc982c3
@crystarm
crystarm force-pushed the fix/phpdbg-property-hook-opcodes branch from b8a948d to fc982c3 Compare November 11, 2026 10:30
@crystarm
crystarm changed the base branch from master to PHP-8.4 November 11, 2026 10:31
@crystarm

crystarm commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

cc @sebastianbergmann

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

SAPI: phpdbg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

phpdbg's opcode listing does not include the bodies of property hooks

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@crystarm @bwoebi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.