GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — Fix test to use non-interned string by rr-it · Pull Request #25370 · php/php-src Conversation
|
| if (mult == 1) { | |
| RETURN_STR_COPY(input_str); | |
| } |
Further random_int(1, 1) is optimized since PHP 7:
Lines 171 to 173 in c12917a
| if (min == max) { | |
| RETURN_LONG(min); | |
| } |
Implemented with c12917a and further refactored with b14dd85 and 4d8dd8d.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Wrong commit pointed, str_repeat got optimized such that passing 1 returns the input string, that's the root cause not the ext/random changes. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
@ndossche That one fixes it. Do you add a new PR or shall I?
This alternative actually works to create non-interned strings: $strInterned = "my valid"; $strNonInterned = $strInterned . " string"; Also see: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
e468c25 to
4fedde6
Compare
|
This made it into 8.6, so the target branch should be PHP-8.6. You may do the fixes in this PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
4fedde6 to
b31b3bc
Compare
|
Commit rebased on branch |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.