GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ext/opcache: tracing JIT drops reference type of a named by-ref argum… by devnexen · Pull Request #25377 · php/php-src

Conversation

@devnexen

@devnexen devnexen commented Nov 10, 2026

Copy link
Copy Markdown
Member

…ent.

Fix GH-25359

zend_jit_trace_build_tssa() narrowed SEND_VAR_EX op1_def to the by-value type using op2.num, which is the name literal for a named argument. The callee looked by-value, so the CV lost MAY_BE_REF and the ref leaked or was returned unwrapped. Skip the narrowing for named arguments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@devnexen
ext/opcache: tracing JIT drops reference type of a named by-ref argum…
eb9fdd7 
…ent.

Fix phpGH-25359

zend_jit_trace_build_tssa() narrowed SEND_VAR_EX op1_def to the by-value
type using op2.num, which is the name literal for a named argument. The
callee looked by-value, so the CV lost MAY_BE_REF and the ref leaked or
was returned unwrapped. Skip the narrowing for named arguments.
@github-actions github-actions Bot added the Extension: opcache label Nov 10, 2026
@devnexen devnexen linked an issue Nov 10, 2026 that may be closed by this pull request
Tracing JIT: Assertion in _get_zval_ptr_tmp: TMP holds a reference after by-ref named-argument call (incomplete fix of GH-21972) #25359
Closed
@devnexen
devnexen marked this pull request as ready for review November 10, 2026 21:35
@devnexen
devnexen requested a review from dstogov as a code owner November 10, 2026 21:35
@iliaal

iliaal commented Nov 10, 2026

Copy link
Copy Markdown
Member

Fix looks right. gh25359.phpt passes unpatched for me on NTS and ZTS debug builds (with ZEND_VERIFY_TYPE_INFERENCE too). Does it need ASAN to fail? gh25359_2.phpt does pin it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@devnexen
feedback
6f0bd58
iliaal
iliaal approved these changes Nov 12, 2026
View reviewed changes

@iliaal iliaal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the fixes, g2g now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@devnexen devnexen closed this in cde751d Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iliaal iliaal iliaal approved these changes
@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Extension: opcache

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracing JIT: Assertion in _get_zval_ptr_tmp: TMP holds a reference after by-ref named-argument call (incomplete fix of GH-21972)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@devnexen @iliaal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.