GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix the imagecropauto() threshold color error message by lacatoire · Pull Request #25385 · php/php-src

Conversation

@lacatoire

@lacatoire lacatoire commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

imagecropauto() in threshold mode reports "must be greater than or equal to 0" for a non-negative colour that is not an index of the palette. Report the palette bound separately.

$p = imagecreate(6, 6);
imagecolorallocate($p, 255, 255, 255);
imagecolorallocate($p, 10, 10, 10);
imagecropauto($p, IMG_CROP_THRESHOLD, 0.5, imagecolorstotal($p));

Before: ValueError: imagecropauto(): Argument #4 ($color) must be greater than or equal to 0 when using the threshold mode

After: ValueError: imagecropauto(): Argument #4 ($color) must be a valid color index of the image when using the threshold mode

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lacatoire
ext/gd: report the palette bound of the imagecropauto() threshold color
aa12ee6
@lacatoire
lacatoire requested a review from devnexen as a code owner November 11, 2026 09:39
@github-actions github-actions Bot added the Extension: gd label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Extension: gd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@lacatoire
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.