GeezerVison is showing github.com — Fix the imagecropauto() threshold color error message by lacatoire · Pull Request #25385 · php/php-src
Conversation
lacatoire
commented
Nov 11, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
imagecropauto() in threshold mode reports "must be greater than or equal to 0" for a non-negative colour that is not an index of the palette. Report the palette bound separately.
$p = imagecreate(6, 6);
imagecolorallocate($p, 255, 255, 255);
imagecolorallocate($p, 10, 10, 10);
imagecropauto($p, IMG_CROP_THRESHOLD, 0.5, imagecolorstotal($p));
Before: ValueError: imagecropauto(): Argument #4 ($color) must be greater than or equal to 0 when using the threshold mode
After: ValueError: imagecropauto(): Argument #4 ($color) must be a valid color index of the image when using the threshold mode
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
devnexen
Awaiting requested review from devnexen
devnexen is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.