GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||
GeezerVison is showing github.com — Fix uploaded files leak in request_parse_body() by dunglas · Pull Request #25387 · php/php-src Conversation
Member
While working on the "Request lifecycle hooks for SAPIs with a worker mode" RFC, I discovered a bug affecting existing SAPIs. Calling The files from the previous parses are then lost. This patch reuses the existing table instead. Related to #24802 and #24987, but neither the same bug nor the same fix. AI: Claude Code used to find the issue and write the patch.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsCalling request_parse_body() on a multipart request whose body was already parsed (at startup, or by a previous call) replaced SG(rfc1867_uploaded_files). The files from the first parse were no longer accepted by is_uploaded_file() and move_uploaded_file(), and were never deleted at the end of the request.
devnexen
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. --- a/ext/standard/tests/http/request_parse_body/multipart_twice.phpt +++ b/ext/standard/tests/http/request_parse_body/multipart_twice.phpt @@ -17,11 +17,29 @@ $tmp_name = $files['file_name']['tmp_name']; var_dump(is_uploaded_file($tmp_name)); -request_parse_body(); +var_dump(request_parse_body()); var_dump(is_uploaded_file($tmp_name)); +$dst = __DIR__ . '/multipart_twice.txt'; +var_dump(move_uploaded_file($tmp_name, $dst)); +var_dump(file_get_contents($dst)); + +?> +--CLEAN-- +<?php +@unlink(__DIR__ . '/multipart_twice.txt'); ?> --EXPECT-- bool(true) +array(2) { + [0]=> + array(0) { + } + [1]=> + array(0) { + } +} +bool(true) bool(true) +string(9) "file data"
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. --- a/ext/standard/tests/http/request_parse_body/multipart_after_startup_parse.phpt +++ b/ext/standard/tests/http/request_parse_body/multipart_after_startup_parse.phpt @@ -14,11 +14,29 @@ $tmp_name = $_FILES['file_name']['tmp_name']; var_dump(is_uploaded_file($tmp_name)); -request_parse_body(); +var_dump(request_parse_body()); var_dump(is_uploaded_file($tmp_name)); +$dst = __DIR__ . '/multipart_after_startup_parse.txt'; +var_dump(move_uploaded_file($tmp_name, $dst)); +var_dump(file_get_contents($dst)); + +?> +--CLEAN-- +<?php +@unlink(__DIR__ . '/multipart_after_startup_parse.txt'); ?> --EXPECT-- bool(true) +array(2) { + [0]=> + array(0) { + } + [1]=> + array(0) { + } +} +bool(true) bool(true) +string(9) "file data"
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 2 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |