GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix GH-25388: Stale ext/date tz cache after logging during startup by lazerg · Pull Request #25407 · php/php-src

Conversation

@lazerg

@lazerg lazerg commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

When an error is logged during module startup, php_format_date() fills DATEG(tzcache) with startup memory. That memory is freed before the first request, but the pointer stays set, so a log written at request startup before RINIT (here the missing output_handler) reads the freed table. On the other hand, a cache built at request startup leaked, because RINIT reset the pointer to NULL.

The cache is now skipped while the executor is not active, and RINIT no longer clears it, since post-deactivate already frees it and sets it back to NULL.

Fixes #25388

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lazerg
Fix phpGH-25388: Stale ext/date tz cache after logging during startup
6913b72
@lazerg
lazerg requested a review from derickr as a code owner November 12, 2026 04:00
@github-actions github-actions Bot added the Extension: date label Nov 12, 2026
@lazerg
Use the issue title in the phpGH-25388 test
3517fdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Extension: date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@lazerg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.