GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Zend: delayed OOM clears the opline of a frame mid-op. by devnexen · Pull Request #25408 · php/php-src

Conversation

@devnexen

@devnexen devnexen commented Nov 12, 2026

Copy link
Copy Markdown
Member

Fix #25304

zend_handle_delayed_oom() always reset EG(opline_before_exception) to NULL, even when called from zend_call_function() in the middle of an opcode. The JIT exception handler stubs then dereferenced it. Only the VM and JIT interrupt handlers run between two opcodes, so they now clear it instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@devnexen
Zend: delayed OOM clears the opline of a frame mid-op.
f4175ed 
Fix php#25304

zend_handle_delayed_oom() always reset EG(opline_before_exception) to NULL,
even when called from zend_call_function() in the middle of an opcode. The
JIT exception handler stubs then dereferenced it. Only the VM and JIT
interrupt handlers run between two opcodes, so they now clear it instead.
@github-actions github-actions Bot added Category: Engine Extension: opcache ABI break labels Nov 12, 2026
@devnexen
devnexen marked this pull request as ready for review November 12, 2026 05:01
@devnexen
devnexen requested a review from dstogov as a code owner November 12, 2026 05:01
@devnexen devnexen assigned arnaud-lb Nov 12, 2026
iliaal
iliaal approved these changes Nov 12, 2026
View reviewed changes

@iliaal iliaal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reproduced the segfault under function and tracing JIT on an NTS debug 8.4 build; gone with the patch. This is an 8.4.28RC1 regression, so it should land before GA.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iliaal iliaal iliaal approved these changes
@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@arnaud-lb arnaud-lb

Labels

ABI break Category: Engine Extension: opcache

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@devnexen @iliaal @arnaud-lb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.