GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix GH-25415: Segfault in FilterIterator::next() after failed parent ctor by lazerg · Pull Request #25417 · php/php-src

Conversation

@lazerg

@lazerg lazerg commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

When a closed generator is passed to parent::__construct() of a dual iterator, the constructor throws after the object is already marked as constructed, so inner.iterator stays NULL. If the subclass catches the exception, spl_dual_it_next() only checked for a NULL inner iterator when do_free was 0, so next() on FilterIterator, IteratorIterator, LimitIterator and friends dereferenced it. NoRewindIterator had the same problem in valid(), key(), current() and next().

The NULL check in spl_dual_it_next() now runs in both cases, and the NoRewindIterator methods behave like the other iterators here: valid() returns false, key() and current() return NULL, and next() throws the existing "inner constructor wasn't initialized" error.

Fixes #25415

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lazerg
Fix phpGH-25415: Segfault in FilterIterator::next() after failed pare…
a8a8ebe 
…nt ctor
@lazerg
lazerg requested a review from Girgias as a code owner November 12, 2026 11:52
@github-actions github-actions Bot added the Extension: spl label Nov 12, 2026
@lazerg

lazerg commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

The LINUX_X32_DEBUG_ZTS Tracing JIT failure also happens on PHP-8.4 itself (runs 43196288502 and 43186660061), so it isn't caused by this change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Extension: spl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@lazerg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.