GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Throw Error when referencing uninit prop in __sleep by nikic · Pull Request #5050 · php/php-src

Conversation

@nikic

@nikic nikic commented Jan 3, 2020

Copy link
Copy Markdown
Member

Variant discussed on #5027.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nikic
Throw Error when referencing uninit prop in __sleep
6bb1efa
@nikic nikic mentioned this pull request Jan 3, 2020
Change __sleep serialization for uninitialized typed properties #5027
Closed
TysonAndre
TysonAndre reviewed Jan 3, 2020
View reviewed changes
Comment thread ext/standard/var.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nikic
Use break instead of goto exit
1bdf86e
@TysonAndre

TysonAndre commented Jan 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

LGTM for the implementation - https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=4579&view=logs&j=0d3730b8-0d59-574b-ab4a-5e189a74d53b&t=16356ba5-7ea0-592f-2d28-e33b9eb7fc21 time_sleep_until failure seems spurious
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@php-pulls php-pulls closed this in 846b647 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TysonAndre TysonAndre TysonAndre left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nikic @TysonAndre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.