GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [RFC] Partial Function Application by krakjoe · Pull Request #6898 · php/php-src

Conversation

krakjoe commented Apr 22, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Implementation for https://wiki.php.net/rfc/partial_function_application

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Crell, KennedyTedesco, azjezz, rentalhost, Dragomeat, klimick, jakobkolb, root-aza, vudaltsov, someniatko, and 23 more reacted with thumbs up emoji

myForksFiles, zlianon, mvorisek, and ging-dev reacted with thumbs down emoji

francislavoie, azjezz, byanelli, faizanakram99, mikield, and omgmashina reacted with hooray emoji

azjezz, sirsnyder, KennedyTedesco, rentalhost, jakobkolb, Crell, Dragomeat, klimick, root-aza, vudaltsov, and 17 more reacted with heart emoji

francislavoie, ziaratban, azjezz, byanelli, faizanakram99, mikield, omgmashina, and alexpts reacted with rocket emoji

All reactions

👍 33 reactions
👎 4 reactions
🎉 6 reactions
❤️ 27 reactions
🚀 8 reactions

krakjoe added the RFC label

Apr 22, 2021

azjezz reviewed

Apr 22, 2021

View reviewed changes

Comment thread

Zend/zend_partial.stub.php Resolved

Uh oh!

There was an error while loading. Please reload this page.

krakjoe closed this

Apr 24, 2021

krakjoe reopened this

Apr 24, 2021

krakjoe closed this

Apr 26, 2021

krakjoe reopened this

Apr 26, 2021

azjezz mentioned this pull request

Apr 26, 2021

support generic variables vimeo/psalm#3963

Closed

krakjoe force-pushed the partials branch from b6a3638 to a75987f Compare

April 26, 2021 16:51

krakjoe commented

Apr 30, 2021

View reviewed changes

Comment thread

Zend/Optimizer/zend_call_graph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_object_handlers.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_opcode.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_vm_def.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

ext/reflection/php_reflection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

ext/reflection/php_reflection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

ext/reflection/php_reflection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

ext/reflection/tests/ReflectionExtension_getClasses_basic.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

krakjoe force-pushed the partials branch from a00d67a to a11b43e Compare

May 11, 2021 01:52

nikic commented May 12, 2021

Copy link

Copy Markdown

Member

I'm missing a test for __call/__callStatic trampolines.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nikic reviewed

May 12, 2021

View reviewed changes

Comment thread

Zend/tests/partial_function/nested.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/tests/partial_function/object.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/tests/partial_function/reflection.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/tests/partial_function/type-check.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/tests/partial_function/variadics-named-nested-overwrite.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

dkulyk reviewed

May 13, 2021

View reviewed changes

Comment thread

Zend/tests/partial_function/named-args.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

nicolas-grekas reviewed

May 13, 2021

View reviewed changes

Comment thread

Zend/tests/partial_function/reflection-resolver.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

POPSuL reviewed

May 13, 2021

View reviewed changes

Comment thread

Zend/tests/partial_function/object-constructor.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

krakjoe force-pushed the partials branch from 17ba8a6 to a85b760 Compare

May 14, 2021 10:34

nikic reviewed

May 14, 2021

View reviewed changes

Comment thread

Zend/zend_ast.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/tests/partial_function/type-check.phpt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_closures.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

nikic reviewed

May 14, 2021

View reviewed changes

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

ext/reflection/php_reflection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_vm_def.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_vm_def.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_vm_def.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_vm_def.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

nikic reviewed

May 14, 2021

View reviewed changes

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_vm_def.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

nikic reviewed

May 14, 2021

View reviewed changes

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Outdated

nikic May 14, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for the new Foo(?) case, we first create an object, then destroy it and then if the partial is invoked, create another object.

This is non-great, though I'm not sure just how non-great it is. In conjunction with https://wiki.php.net/rfc/new_in_initializers it could mean that property default values get instantiated and immediately dropped again (though arguably that's an issue with that RFC).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

krakjoe May 14, 2021

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have space for a flag, we could use IS_OBJ_CONSTRUCTOR_CALLED here and use the initial object ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

krakjoe force-pushed the partials branch from 54d8c55 to 9c67617 Compare

May 15, 2021 13:00

krakjoe closed this

May 19, 2021

krakjoe reopened this

May 28, 2021

krakjoe marked this pull request as draft

May 28, 2021 08:52

krakjoe force-pushed the partials branch 2 times, most recently from d264f87 to 61e7f1e Compare

May 29, 2021 16:24

krakjoe marked this pull request as ready for review

May 29, 2021 16:58

krakjoe force-pushed the partials branch 3 times, most recently from 11123b8 to 286e16f Compare

May 29, 2021 20:55

krakjoe added 2 commits

June 17, 2021 18:25


          comments

88aa29c


          drop silly macro

81b64ff

This comment has been minimized.


          fix another gc issue

67c3b66

This comment has been minimized.


          fix uaf in unfinished calls, fix leak args

3f8a12a

nikic reviewed

Jun 18, 2021

View reviewed changes

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Zend/zend_partial.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

This comment has been minimized.

krakjoe added 3 commits

June 18, 2021 17:18


          put assert back

bde700f


          fix indent, repeat type

b699d65


          use hash add variants

0e8a0a0

This comment has been minimized.

krakjoe added 3 commits

June 18, 2021 17:29


          insert null in debug info

711b33a


          drop sprintf for zend_string_init

9400a69


          fix uaf, order of destruction

583264d

This comment has been minimized.


          set ce ptr

6afa0d1

This comment has been minimized.


          fix null ptr deref

12d6006

This comment has been minimized.


          fix wrong signature check

fd62047

This comment has been minimized.

patrickallaert reviewed

Jun 19, 2021

View reviewed changes

Comment thread

ext/reflection/php_reflection.c

Comment on lines +1326 to +1328

		}
		ZEND_ASSERT(0);
		return -1;

patrickallaert Jun 19, 2021

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation: mix of tabs and spaces.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

thekid mentioned this pull request

Jun 27, 2021

Implement partial function application xp-framework/compiler#113

Closed

faizanakram99 commented Jul 1, 2021

Copy link

Copy Markdown

We lost :(

someniatko, innocenzi, ddziaduch, root-aza, meszaros-lajos-gyorgy, verfriemelt-dot-org, jurchiks, mhitza, kasumikagari, Dewdrops, and 6 more reacted with confused emoji

All reactions

😕 16 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

krakjoe closed this

Jul 1, 2021

POPSuL commented Jul 1, 2021

Copy link

Copy Markdown

What's next? Will there be an alternative from Nikita, or your collaboration?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nikic mentioned this pull request

Jul 13, 2021

Partial function application #5547

Closed

jurchiks commented Feb 25, 2022

Copy link

Copy Markdown

Damn shame, it looks to me like a very useful feature to have.

zmitic, Dewdrops, x0s, tianyiw2013, CViniciusSDias, zejji, epic-64, rvanlaak, gnutix, and jorbascrumps reacted with thumbs up emoji

All reactions

👍 10 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arnaud-lb mentioned this pull request

Jun 20, 2025

Partials v2 arnaud-lb/php-src#12

Draft

7 of 10 tasks

Reviewers

kamil-tekiela

kamil-tekiela left review comments

+10 more reviewers

patrickallaert

patrickallaert left review comments

drealecs

drealecs left review comments

nikic

nikic left review comments

nicolas-grekas

nicolas-grekas left review comments

Crell

Crell left review comments

dkulyk

dkulyk left review comments

POPSuL

POPSuL left review comments

francislavoie

francislavoie left review comments

someniatko

someniatko left review comments

azjezz

azjezz left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

RFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

14 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

krakjoe commented Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikic commented May 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikic May 14, 2021

Choose a reason for hiding this comment

Uh oh!

krakjoe May 14, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

patrickallaert Jun 19, 2021

Choose a reason for hiding this comment

Uh oh!

faizanakram99 commented Jul 1, 2021

Uh oh!

POPSuL commented Jul 1, 2021

krakjoe commented Apr 22, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.