GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: remove init_oparray function by carlos-granados · Pull Request #38 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator

The xdebug_init_oparray function did not have any functionality after removing all the additional modes. This function was called every time an oparray was constructed. This PR removes this function and the handler call in the extension which should improve performance a little

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 4, 2026
@carlos-granados
carlos-granados requested a review from pronskiy April 4, 2026 13:40
@pronskiy

pronskiy commented Apr 7, 2026

Copy link
Copy Markdown
Member

nitpick:
i'd prefix with refactor: as it does not add any features.

lgtm, rebase and merge 🫡
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pronskiy
pronskiy approved these changes Apr 7, 2026
View reviewed changes
@carlos-granados
refactor: remove init_oparray function
cb28618
@carlos-granados
carlos-granados force-pushed the feature/remove-init-op-array branch from 77eea57 to cb28618 Compare April 7, 2026 23:05
@carlos-granados carlos-granados changed the title feat: remove init_oparray function refactor: remove init_oparray function Apr 7, 2026
@carlos-granados
carlos-granados merged commit 6b0b321 into php-debugger:main Apr 7, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@carlos-granados
carlos-granados deleted the feature/remove-init-op-array branch April 7, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiy pronskiy pronskiy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.