GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix warnings raised by the compiler by carlos-granados · Pull Request #46 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator
  • When running the tests compile the code with warnings using the --enable-php-debugger-dev flag when configuring (this flag has been renamed from the old --enable-xdebug-dev name
  • Fix existing warnings which had not been found because we had not been using this option, mainly removes unused functions and variables and makes sure that variable declaration is not mixed with code
  • Apply two new warnings -Wstrict-prototypes and -Wold-style-definition and fix the issues found by them

This is probably better reviewed by looking at the individual commits

Note: I was not able to apply the -Wmissing-prototypes warning because our code uses several Zend macros which define functions without adding a prototype

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
carlos-granados added 4 commits April 18, 2026 08:52
@carlos-granados
Change flag name and use warnings when testing
0d913b7
@carlos-granados
Fixes existing warnings found by the compiler
dfe4e1b
@carlos-granados
Apply -Wstrict-prototypes warning
f6f0298
# Conflicts:
#	src/base/base.h
@carlos-granados
Apply -Wold-style-definition
785d38a
@carlos-granados
carlos-granados force-pushed the fix/compiler-warnings branch from 5755648 to 785d38a Compare April 18, 2026 06:55
@pronskiy

pronskiy commented Apr 19, 2026

Copy link
Copy Markdown
Member

Lgtm 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados merged commit 1cd4ef3 into php-debugger:main Apr 19, 2026
13 of 15 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados deleted the fix/compiler-warnings branch April 19, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.