GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix: match dtor function signatures to silence UBSan function-type check by pronskiy · Pull Request #52 · php-debugger/php-debugger Conversation
Member
Fixes #50
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsDestructor functions stored in hash/llist dtor slots were defined with typed parameters and cast to the generic void(*)(void*) slot type. UBSan's -fsanitize=function flags calls through a mismatched pointer as undefined behavior, aborting in post-deactivate during request shutdown and breaking dbgp tests downstream. Change the dtors to take void* and cast internally so the pointer type matches the callee's real signature; drop the now-unnecessary casts at registration sites. Wrap zend_string_release in a local dtor since its signature is fixed.
pronskiy
force-pushed
the
fix/asan-ubsan-issues
branch
from
745c431 to
7dfa442
Compare
pronskiy
marked this pull request as draft
pronskiy
marked this pull request as ready for review
carlos-granados
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These seem to be changes only made to please the tool but I guess they are harmless, let's go ahead with them
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. The dtor registration pattern (casting typed destructors to the generic xdebug hash/llist dtor slot types) is shared with upstream Xdebug and works correctly on all supported platforms, but trips UBSan's -fsanitize=function indirect-call type check. Suppress the check at build time rather than diverge from upstream source.
carlos-granados
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, better
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Fix ASAN + UBSAN issuesUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |