GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — refactor: remove all checks for debug mode by carlos-granados · Pull Request #53 · php-debugger/php-debugger Conversation
Collaborator
Since we don't have any mode other than debug, we can remove all cases where we were checking if the mode was debug. The only other possible mode is off and all these places will not be called when the mode is off
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
carlos-granados
force-pushed
the
refactor/remove-debug-mode-checks
branch
from
9d90492 to
c7d54c0
Compare
pronskiy
approved these changes
pronskiy
self-requested a review
pronskiy
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tests are failing so far?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
carlos-granados
force-pushed
the
refactor/remove-debug-mode-checks
branch
from
c7d54c0 to
b6e3568
Compare
carlos-granados
force-pushed
the
refactor/remove-debug-mode-checks
branch
from
b6e3568 to
078859c
Compare
pronskiy
self-requested a review
pronskiy
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 2 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |