GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: remove filter functionality by carlos-granados · Pull Request #55 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented Apr 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The filters were only used in code coverage, stack traces in develop mode, and tracing, they are not used at all for debugging, so I removed all this extra code, including tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@carlos-granados
carlos-granados force-pushed the refactor/remove-filters branch from 71e7fe0 to 084c9bf Compare April 18, 2026 06:55
@pronskiy

pronskiy commented Apr 19, 2026

Copy link
Copy Markdown
Member

You can probably remove this thing from lib.h:
/* filter properties */
unsigned char filtered_stack;

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados force-pushed the refactor/remove-filters branch from d917c5f to 943fa04 Compare April 19, 2026 19:35
@carlos-granados

carlos-granados commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator Author

You can probably remove this thing from lib.h: /* filter properties */ unsigned char filtered_stack;

Thanks, updated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados force-pushed the refactor/remove-filters branch from 943fa04 to 4838acc Compare April 19, 2026 21:05
carlos-granados added 2 commits April 22, 2026 18:18
@carlos-granados
refactor: remove filter functionality
dbee3fd
# Conflicts:
#	config.m4
#	config.w32
#	src/base/filter.c

# Conflicts:
#	src/base/base.c
@carlos-granados
refactor: remove unneeded variable
d7b767f
@carlos-granados
carlos-granados force-pushed the refactor/remove-filters branch from 4838acc to d7b767f Compare April 22, 2026 16:18
@pronskiy

pronskiy commented May 1, 2026

Copy link
Copy Markdown
Member
  1. these in src/base/base_globals.h:81-83 probably redundant:
/* filters */
zend_long     filter_type_stack;
xdebug_llist *filters_stack;

For keeping BC, how about adding xdebug_set_filter() stub to src/lib/compat_stubs.c/h ?

Also for BC sakes, makes sense to keep the constants, but just move them to compat_stubs:
XDEBUG_FILTER_, XDEBUG_PATH_, XDEBUG_NAMESPACE_*

wdyt?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
Add back xdebug_set_filter function and filter constants for backward…
f590692
…s compatibility
@carlos-granados

carlos-granados commented May 2, 2026

Copy link
Copy Markdown
Collaborator Author
  1. these in src/base/base_globals.h:81-83 probably redundant:
/* filters */
zend_long     filter_type_stack;
xdebug_llist *filters_stack;

Removed

For keeping BC, how about adding xdebug_set_filter() stub to src/lib/compat_stubs.c/h ?

Also for BC sakes, makes sense to keep the constants, but just move them to compat_stubs: XDEBUG_FILTER__, XDEBUG_PATH__, XDEBUG_NAMESPACE_*

wdyt?

Good shout, added back to compat_stubs

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados requested a review from pronskiy May 2, 2026 16:40
pronskiy
pronskiy approved these changes May 2, 2026
View reviewed changes
@pronskiy

pronskiy commented May 2, 2026

Copy link
Copy Markdown
Member

👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados merged commit 67ac685 into php-debugger:main May 2, 2026
14 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados deleted the refactor/remove-filters branch May 2, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiy pronskiy pronskiy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.