GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix benchmark results by carlos-granados · Pull Request #58 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

When calculating benchmark results there was an error, when loading the previous results we were converting the previous overhead to an int. This meant that a previous overhead of 15.4 would be converted to 15, for example, skewing the comparison results. This PR fixes this problem

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados
fix benchmark results
a61b3e9
@carlos-granados
carlos-granados requested a review from pronskiy April 17, 2026 05:41
pronskiy
pronskiy approved these changes Apr 19, 2026
View reviewed changes

@pronskiy pronskiy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados
carlos-granados merged commit 194572e into php-debugger:main Apr 19, 2026
13 of 15 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@carlos-granados
carlos-granados deleted the fix/benchmark-results branch April 19, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiy pronskiy pronskiy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.