GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix DBGP emulator handling only one command by carlos-granados · Pull Request #62 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator

When I created this emulator, I only tested it with a "commands" file which only contained one command but when I actually tried to use it with more commands I found out that only the first command was passed. Turns out that the doRead() function of the base class always returns null, independently of whether it correctly read some data or not, so the check for the return value always failed 🤦 Turns out that this check is not really needed and checking if the connection has been closed is enough

The explanation is much longer than the fix! 😆

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@carlos-granados
carlos-granados force-pushed the fix/dbgp-emulator branch 2 times, most recently from d7843ff to 2987506 Compare April 22, 2026 16:19
@pronskiy
pronskiy self-requested a review May 4, 2026 00:22
pronskiy
pronskiy approved these changes May 4, 2026
View reviewed changes
@carlos-granados
Fix DBGP emulator handling only one command
74c3d17
@carlos-granados
carlos-granados force-pushed the fix/dbgp-emulator branch from 2987506 to 74c3d17 Compare May 4, 2026 11:27
@carlos-granados
carlos-granados merged commit 652f436 into php-debugger:main May 5, 2026
14 of 15 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@carlos-granados
carlos-granados deleted the fix/dbgp-emulator branch May 5, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiy pronskiy pronskiy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.