GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: remove all code for PHP versions lower than 8.2 by carlos-granados · Pull Request #69 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented May 2, 2026

Copy link
Copy Markdown
Collaborator

Removes all remaining code that targeted versions of PHP lower than 8.2, which is the lowest version that we support

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pronskiy
pronskiy reviewed May 2, 2026
View reviewed changes
Comment thread src/lib/var_export_html.c Outdated
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wdeclaration-after-statement"
# endif
# include "zend_enum.h"

@pronskiy pronskiy May 2, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, this is now under if !defined(_MSC_VER), isn't it? Same below

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@carlos-granados carlos-granados May 2, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I removed the wrong #endif, did not notice it because under linux this compiles fine, only noticed it when the code was compiled in Windows in CI. Now fixed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados
carlos-granados force-pushed the refactor/remove-code-below-8.2 branch from a237607 to 4475810 Compare May 2, 2026 21:40
@carlos-granados
refactor: remove all code for PHP versions lower than 8.2
554155a 
# Conflicts:
#	src/base/base.c

# Conflicts:
#	src/base/base.c
@carlos-granados
carlos-granados force-pushed the refactor/remove-code-below-8.2 branch from 1b57087 to 554155a Compare May 2, 2026 22:00
@carlos-granados
carlos-granados requested a review from pronskiy May 2, 2026 22:02
pronskiy
pronskiy approved these changes May 3, 2026
View reviewed changes
@carlos-granados
carlos-granados merged commit 98e965e into php-debugger:main May 3, 2026
15 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@carlos-granados
carlos-granados deleted the refactor/remove-code-below-8.2 branch May 3, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiy pronskiy pronskiy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.