GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: add auto-labeling for trusted PRs and improve Claude code review workflow by pronskiy · Pull Request #74 · php-debugger/php-debugger

Conversation

@pronskiy

@pronskiy pronskiy commented May 4, 2026

Copy link
Copy Markdown
Member

The problem is that if a pull request is coming from a fork, then secrets are not available. If you make them available by switching to on: pull_request_target, then, in theory, an attacker could create a pull request from a fork and steal secrets. So I'm adding a labeling guard to fix this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pronskiy
fix: add auto-labeling for trusted PRs and improve Claude code review…
1554c17 
… workflow
carlos-granados
carlos-granados reviewed May 5, 2026
View reviewed changes
Comment thread .github/workflows/claude-code-review.yml
# - "src/**/*.tsx"
# - "src/**/*.js"
# - "src/**/*.jsx"
pull_request_target:

@carlos-granados carlos-granados May 5, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this workflow depend on the other workflow? Otherwise by the time this one runs the PR may not have been labelled yet. Maybe it is best to move the labelling job here and make this workflow a two job workflow, with the second one depending on the first one

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pronskiy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@pronskiy pronskiy May 6, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 🙏

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pronskiy
refactor: consolidate CLA Claude workflows into single file, enhance …
f957cf6 
…auto-labeling and review gate logic
@pronskiy
pronskiy requested a review from carlos-granados May 6, 2026 21:09
carlos-granados
carlos-granados reviewed May 7, 2026
View reviewed changes
Comment thread .github/workflows/claude-code-review.yml Outdated
steps:
- name: Auto-label trusted authors
if: |
github.event.pull_request.user.login == 'pronskiy' ||

@carlos-granados carlos-granados May 7, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked claude if there was a way to check if the PR creator was a privileged user so that we did not need to hardcode our usernames here and it suggested this code:

if: >
  github.event.pull_request.author_association == 'OWNER' ||
  github.event.pull_request.author_association == 'MEMBER'

Maybe we should try this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pronskiy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
carlos-granados
carlos-granados approved these changes May 7, 2026
View reviewed changes

@carlos-granados carlos-granados left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pronskiy
update(claude-code-review.yml): refine auto-labeling logic to use aut…
c277a74 
…hor_association instead of hardcoded usernames
@pronskiy
pronskiy merged commit 1db60bf into main May 7, 2026
13 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@pronskiy
pronskiy deleted the fix/claude-review branch May 7, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-granados carlos-granados carlos-granados approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pronskiy @carlos-granados
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.