GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: recover Windows test runs by carlos-granados · Pull Request #89 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented May 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Recovers testing on Windows which had been removed on a previous step.

Main problem was that we had defined the extension as having the name debugger, not php-debugger. This meant that some checks for the COMPILE_DL_PHP_DEBUGGER flag were not working as it was actually being set as COMPILE_DL_DEBUGGER. Updating config.m4 to use this correct name fixes the problem and all tests on Windows are now passing 👍

Notice that now the DLL is named php_php_debugger.dll. This is correct as Windows DLLs are all named php_name_of_the extension.dll so the duplicate php_ bit matches the standard

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados
carlos-granados force-pushed the feat/recover-windows-tests branch 19 times, most recently from 6c8aea4 to 06f36c2 Compare May 17, 2026 18:27
@carlos-granados
feat: recover windows-tests
1b2cb57
@carlos-granados
carlos-granados force-pushed the feat/recover-windows-tests branch from 06f36c2 to 1b2cb57 Compare May 17, 2026 18:33
carlos-granados
carlos-granados commented May 17, 2026
View reviewed changes
Comment thread tests/debugger/remote_log-win.phpt
[%d] [Step Debug] WARN: Creating socket for 'doesnotexist3:9003', getaddrinfo: %d.
[%d] [Step Debug] WARN: Could not connect to client host discovered through HTTP headers, connecting to configured address/port: doesnotexist2:9003.
[%d] [Step Debug] WARN: Creating socket for 'doesnotexist2:9003', getaddrinfo: 11001.
[%d] [Step Debug] DEBUG: Adding header 'Content-type: %s'.

@carlos-granados carlos-granados May 17, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests needs updating the same way as all the other remote-log tests with the extra debugging output for headers. I had not updated it previously because it only runs on Windows, so I had not noticed that it was failing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados
carlos-granados requested a review from pronskiy May 17, 2026 18:39
pronskiy
pronskiy approved these changes May 17, 2026
View reviewed changes

@pronskiy pronskiy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados
carlos-granados merged commit 42c8ae2 into php-debugger:main May 18, 2026
35 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@carlos-granados
carlos-granados deleted the feat/recover-windows-tests branch May 18, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiy pronskiy pronskiy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.