GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: build more versions on release by carlos-granados · Pull Request #92 · php-debugger/php-debugger

Conversation

@carlos-granados

@carlos-granados carlos-granados commented Jun 18, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator
  • Build both TS and NTS versions for Linux and MacOS
  • Build both arm64 and x86_64 versions for Linux and MacOS

Sample release in my fork: https://github.com/carlos-granados/php-debugger/releases/tag/test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carlos-granados
carlos-granados requested a review from pronskiy June 18, 2026 17:42
@carlos-granados
carlos-granados force-pushed the feature/update-release-job branch 3 times, most recently from 91d441f to 4f15fdd Compare June 18, 2026 18:08
@carlos-granados
carlos-granados marked this pull request as draft June 18, 2026 18:14
@carlos-granados
carlos-granados force-pushed the feature/update-release-job branch 2 times, most recently from 47a7172 to 8bcdb64 Compare June 18, 2026 18:51
@carlos-granados
carlos-granados marked this pull request as ready for review June 18, 2026 19:00
pronskiy
pronskiy reviewed Jun 29, 2026
View reviewed changes
Comment thread .github/workflows/release.yml Outdated
$dll = Get-ChildItem -Path $env:RUNNER_TEMP -Recurse -Filter 'php_php_debugger.dll' -ErrorAction SilentlyContinue | Select-Object -First 1
if (-not $dll) {
$dll = Get-ChildItem -Recurse -Filter 'php_php_debugger.dll' -ErrorAction SilentlyContinue | Select-Object -First 1
$assetName = "php_php_debugger-php${phpVer}-${tsTag}-windows-x64.dll"

@pronskiy pronskiy Jun 29, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems inconsistent with macos and linux assets naming, isn't it?

ASSET_NAME="php-debugger-php${PHP_VER}-${TS_TAG}-${OS_TAG}-${ARCH_TAG}.so"
$assetName = "php_php_debugger-php${phpVer}-${tsTag}-windows-x64.dll"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@carlos-granados carlos-granados Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By convention PHP extension DLLs in Windows have a name that starts with php_ but the second _ should have been a - to match the Linux/MacOs assets, updated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pronskiy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@carlos-granados
carlos-granados requested a review from pronskiy June 30, 2026 13:09
@carlos-granados
carlos-granados force-pushed the feature/update-release-job branch from 8f6d3b9 to 44bd20d Compare June 30, 2026 13:38
pronskiy
pronskiy approved these changes Jul 1, 2026
View reviewed changes
carlos-granados added 2 commits July 1, 2026 22:19
@carlos-granados
feat: Build more versions on release
37c554c
@carlos-granados
Update asset names in Windows
f221b8b
@carlos-granados
carlos-granados force-pushed the feature/update-release-job branch from 44bd20d to f221b8b Compare July 1, 2026 20:19
@carlos-granados
carlos-granados merged commit ad151d7 into php-debugger:main Jul 1, 2026
32 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@carlos-granados
carlos-granados deleted the feature/update-release-job branch July 1, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiy pronskiy pronskiy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@carlos-granados @pronskiy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.