Description

olivernybroe

opened on Sep 11, 2019

Issue body actions

So in PHP we can make a method reference by using this syntax right now

Route::get('users', [UserController::class, 'index']);

I propose that we add a short method reference syntax like so

Route::get('users', UserController::index);

Reacted by Julian Martin, Miguel Piedrafita, Jonathan Nessier, Oliver Nybroe, Marcin Harasim, Luis Canario and Fidel Aquino

Reacted by John Pedrie

Activity

1. nunomaduro

   added

   rfcNew proposalNew proposal

   on Sep 11, 2019
2. nunomaduro

   changed the title [-][RFC] Short method references[/-] [+]short method references[/+] on Sep 11, 2019
3. stancl commented on Sep 11, 2019

   

   stancl

   on Sep 11, 2019

   More actions

   Should this work only with static access? It could be problematic with access inside the class because you can have a property and a method with the same name. $this->foo() and ($this->foo)() are different things.

   And with static methods, this is already possible. Strings that reference static methods are callable:

   >>> class Bar { public static function xyz() { return 'foo'; } }
   >>> 'Bar::xyz'();
   => "foo"
4. olivernybroe commented on Sep 11, 2019

   

   olivernybroe

   on Sep 11, 2019

   Author

   More actions

   @stancl This should work with non static method also. It should not be used for properties, only methods.
   As in my example, it would basically just be a wrapper for [Bar::class, 'xyz'], as that syntax also supports static methods.

   >>> class Bar { public static function xyz() { return 'foo'; } }
   >>> [Bar::class, 'xyz']();
   => "foo"
   

   The only "problem" I really see with it is that the same syntax is used for constants. However in that case, I think the constant should have priority.
5. enumag commented on Sep 12, 2019

   

   enumag

   on Sep 12, 2019

   More actions

   The only "problem" I really see with it is that the same syntax is used for constants. However in that case, I think the constant should have priority.

   In real world constants are usually written in uppercase and methods in camelcase so it's not a real problem. In my opinion Plus should simply throw an error if a class has both a method and a constant with the same name.

   Reacted by Oliver Nybroe and Fidel Aquino
6. olivernybroe commented on Sep 12, 2019

   

   olivernybroe

   on Sep 12, 2019

   Author

   More actions

   @enumag Yeah, I like the idea of just throwing an error. And the uppercase/camelcase scenario was also why I sad "problem" 👍

Issue actions