GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [ticket/17197] Replace OAuth library by CHItA · Pull Request #7045 · phpbb/phpbb

Conversation

CHItA commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

PHPBB3-17197

Checklist:

Correct branch: master for new features; 3.3.x for fixes
Tests pass
Code follows coding guidelines: master and 3.3.x
Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-12345

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

private-packagist Bot commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

phpBB/composer.lock

Package changes

Package	Operation	From	To	About
league/oauth2-client	add	-	2.9.1	view code - License: MIT License
composer/ca-bundle	upgrade	1.5.12	1.5.14	diff
composer/composer	upgrade	2.10.2 ⚠️	2.10.3 ✅	diff
guzzlehttp/guzzle	upgrade	7.14.0 ⚠️	7.15.5 ✅	diff
guzzlehttp/promises	upgrade	2.5.1	2.5.3	diff
guzzlehttp/psr7	upgrade	2.12.4	2.13.1	diff
justinrainbow/json-schema	upgrade	6.10.0	6.12.0	diff
paragonie/sodium_compat	upgrade	v2.5.0 ⚠️	v2.5.2 ✅	diff
seld/phar-utils	upgrade	1.2.1	1.2.2	diff
carlos-mg89/oauth	remove	0.8.17	-	-

Dev Package changes

Package	Operation	From	To	About
squizlabs/php_codesniffer	upgrade	4.0.1 ⚠️	4.0.4 ✅	diff

Settings · Docs · Powered by Private Packagist

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CHItA force-pushed the ticket/17197 branch 2 times, most recently from 6fd4028 to 082ae9e Compare

September 18, 2026 15:13

private-packagist Bot commented Sep 18, 2026

Copy link

Copy Markdown

The composer.lock diff comment has been updated to reflect new changes in this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CHItA force-pushed the ticket/17197 branch 2 times, most recently from b60c509 to b4d2f0c Compare

September 18, 2026 16:13


          [ticket/17197] Replace OAuth library

64196b1

PHPBB3-17197

CHItA force-pushed the ticket/17197 branch from b4d2f0c to 64196b1 Compare

September 18, 2026 16:42

CHItA requested a review from marc1706

September 19, 2026 08:22

CHItA added 4.0 (Triton) 🔮 dependencies Pull requests that update a dependency file labels

Sep 19, 2026

marc1706 reviewed

Sep 19, 2026

View reviewed changes

Comment thread

phpBB/phpbb/auth/provider/oauth/provider/bitly.php Resolved

Uh oh!

There was an error while loading. Please reload this page.

marc1706 reviewed

Sep 19, 2026

View reviewed changes

Comment thread

phpBB/phpbb/auth/provider/oauth/service/twitter.php

marc1706 Sep 19, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a migration to remove the twitter oauth settings from the config

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

CHItA Sep 19, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be included in the migration - but will double check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

marc1706 reviewed

Sep 27, 2026

View reviewed changes

marc1706 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the lang string in common.php for the twitter oauth provider can also be removed now. Did you already tests this against google, etc. if oauth still works?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

phpBB/composer.json

		"doctrine/dbal": "^4.4",
		"google/recaptcha": "~1.1",
		"guzzlehttp/guzzle": " ^7.0",
		"league/oauth2-client": "2.*",

marc1706 Sep 27, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like

Suggested change

	"league/oauth2-client": "2.*",
	"league/oauth2-client": "^2.8",

or even 2.9

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tests/functions/fixtures/user_delete.xml

		<value>897a897b797c8789997d7979879</value>
		<value>auth.provider.oauth.service.google</value>
		<value>{"accessToken":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","endOfLife":1429959670,"extraParams":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"},"refreshToken":null,"token_class":"OAuth\\\\OAuth2\\\\Token\\\\StdOAuth2Token"}</value>
		<value>{"access_token":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","expires":1429959670,"refresh_token":null,"values":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"}}}</value>

marc1706 Sep 27, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	<value>{"access_token":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","expires":1429959670,"refresh_token":null,"values":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"}}}</value>
	<value>{"access_token":"ya29.YPHwCWVkrvwu1kgbYKiDNYaQ451ZuHy9OEQAGVME8if-WBzR-v7a9ftxbx41kaL)5VLEXB-6qJEvri","expires":1429959670,"refresh_token":null,"values":{"token_type":"Bearer","id_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.KMUFsIDTnFmyG3nMiGM6H9FNFUROf3wh7SmqJp-QV30"}}</value>

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

phpBB/phpbb/auth/provider/oauth/service/base.php

		$credentials = $this->get_service_credentials();

		return [
		'clientId' => $credentials['key'],

marc1706 Sep 27, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm, those don't seem to be the same as the generic provider getRequiredOptions?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

marc1706 Sep 27, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for base get_provider() it will always throw. is there even a point of having the base method then?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

phpBB/phpbb/auth/provider/oauth/oauth.php

		* @var AbstractProvider service OAuth service
		* @since 3.2.3-RC1
		* @changed 3.2.6-RC1 Added redirect_data
		* @psalm-var string[] $vars

marc1706 Sep 27, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybr add a changed here since this is no longer the same type?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Reviewers

marc1706

marc1706 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

4.0 (Triton) 🔮 dependencies

Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

CHItA commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

private-packagist Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

phpBB/composer.lock

Package changes

Dev Package changes

Uh oh!

private-packagist Bot commented Sep 18, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marc1706 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CHItA commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

private-packagist Bot commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.