GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Ticket/17751 Add core.notification_method_messenger_modify_template_vars event (master) by bonelifer · Pull Request #7100 · phpbb/phpbb

Conversation

bonelifer commented Oct 20, 2026

Copy link

Copy Markdown

Member

Checklist:

Correct branch: master for new features; 3.3.x for fixes
Tests pass
Code follows coding guidelines: master and 3.3.x
Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-17751

Master version of #7099. On master notify_using_messenger() loops over the messenger methods, so the event fires once per notification before that loop, and the resulting template_vars are assigned to every messenger method. @since is 3.3.20-RC1, the same as the 3.3.x version.

The test file has the same name as in #7099 but uses a mocked messenger method, because the messenger is a service collection on master. When 3.3.x is merged up, keep this branch's messenger_base.php and test file.

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          [ticket/17751] Add notification messenger template vars event to master

88d97a5

Add core.notification_method_messenger_modify_template_vars to
messenger_base::notify_using_messenger() on master, fired once per
queued notification before the loop over the messenger methods. A
listener can add or change template_vars, which are then assigned to
every messenger method that sends the notification.

This is the master version of the 3.3.x change for the same ticket.
The code differs between the branches, so the 3.3.x commit does not
merge up cleanly. The test uses a mocked messenger method, because the
messenger is a service collection on master.

PHPBB-17751

bonelifer mentioned this pull request

Oct 20, 2026

Ticket/17751 Add core.notification_method_messenger_modify_template_vars event #7099

Open

4 tasks done


          Merge branch 'master' into ticket/17751-master

881add0

marc1706 added Event 🔌 4.0 (Triton) 🔮 labels

Nov 2, 2026

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

4.0 (Triton) 🔮 Event 🔌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.