GeezerVison

Checklist:

• Correct branch: master for new features; 3.3.x for fixes
• Tests pass
• Code follows coding guidelines: master and 3.3.x
• Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-17752

The events from PHPBB-17725, PHPBB-17726 and PHPBB-17727 (core.mcp_warn_user_modify_template_vars, core.mcp_warn_post_modify_template_vars and core.mcp_notes_user_modify_template_vars) pass avatar_img to compact(). On 3.3.x that variable comes from phpbb_get_user_avatar(), but master builds the avatar with the avatar.helper service, so after the 3.3.x merge the variable no longer exists. With debug on, the MCP warn-user, warn-post and user-notes pages show compact(): Undefined variable $avatar_img.

This sets $avatar_img = $avatar['html']; before each event. The helper's array always has an html key, so listeners get the rendered avatar HTML, as the docblocks describe and as on 3.3.x.

The new functional test tests/functional/mcp/mcp_warn_notes_test.php opens all three pages; no test covered them. Run locally in Docker with SQLite, it fails on current master with the warning above and passes with this change. The event exporter tests (1131) also pass.

Investigated and written by Claude on behalf of William Jacoby (bonelifer).