GeezerVison

Checklist:

• Correct branch: master for new features; 3.3.x for fixes
• Tests pass
• Code follows coding guidelines: master and 3.3.x
• Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-17753

\phpbb\ban\manager::unban() logged [$unbanned_users], an array, where ban() logs a joined string. Showing the admin or moderator log then gave Array to string conversion in language::lang_array(), and email and IP unbans named nothing, because after_unban() returns an empty array for those types. This logs the unbanned usernames, or the email addresses or IPs, as one string, the way ban() does.

The user-notes loop also used the values of after_unban() (usernames) as user ids, so unbanned users never got their note. It now loops over the keys.

The new test_unban_logs in tests/ban/ban_manager_test.php covers user, email and IP unbans. Run locally in Docker with SQLite, it fails on current master and passes with this change; the rest of the ban manager tests, the session ban check and the email validation tests also pass.

Log rows already written with an array still warn when shown. This PR leaves them alone; a migration could rewrite them if wanted.

Investigated and written by Claude on behalf of William Jacoby (bonelifer).