GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — [ticket/17768] Double submit issues during poll voting by marc1706 · Pull Request #7115 · phpbb/phpbb Conversation
|
|
The attempt to merge branch
This PR is ready to be merged. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The change still has two critical active issues: guest duplicate submissions remain possible because they lack server-side transaction state, and the locking approach is not atomic on supported non-transactional table engines.
This pull request addresses duplicate poll submissions by validating poll options and serializing registered-user vote updates.
Changes:
| File | Summary |
|---|---|
tests/functional/posting_test.php |
Adds coverage for invalid options and repeated poll submissions, but does not exercise truly concurrent requests. |
phpBB/viewtopic.php |
Validates poll options and coordinates vote updates transactionally; guest requests and non-transactional engines still require handling. |
phpBB/language/en/viewtopic.php |
Adds the message displayed when a vote has already been cast. |
This pull request requires changes.
Review effort: Lite
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
A moderate active finding remains because the test does not reproduce the concurrent double-submit or exercise the transaction re-read branch, so it can pass against the old implementation.
Review effort: Lite
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The fix depends on row-lock and transaction semantics across phpBB’s supported database drivers, and the race lacks automated concurrent coverage, so human validation across those engines is needed.
No open issues 🎉
Review effort: Lite
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.