GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pass explicit trim characters ahead of PHP 8.6 by GrahamCampbell · Pull Request #597 · phpdotenv/phpdotenv

Conversation

@GrahamCampbell

@GrahamCampbell GrahamCampbell commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

PHP 8.6 adds the form feed character to the default $characters set of trim, ltrim, and rtrim, so calls relying on the default would change behavior there. This passes an explicit character set at the five calls that relied on it: the notEmpty validation, comment and whitespace line detection, the name/value split (converted from a callable-string array_map('trim', ...) to a closure so it can carry the set), and blank-value detection all freeze the pre-8.6 set, keeping behavior identical on every PHP version.

The ltrim after the export prefix instead uses the full whitespace set, space, horizontal tab, line feed, carriage return, vertical tab, and form feed, matching the ctype_space guard on the preceding line. That guard already accepts form feed as the separator, but the pre-8.6 default never stripped it, so export followed by a form feed produced an invalid-name error; the two now agree on every PHP version. An audit of the rest of the package found nothing else: all other regex work goes through the Util\Regex result wrapper with PCRE error reporting, and every pattern is anchored with \A/\z or the A modifier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@GrahamCampbell
Pass explicit trim characters ahead of PHP 8.6
350061a
@GrahamCampbell
GrahamCampbell merged commit 416df70 into master Jul 6, 2026
38 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@GrahamCampbell
GrahamCampbell deleted the trim-characters branch July 6, 2026 19:12
@GrahamCampbell GrahamCampbell mentioned this pull request Aug 23, 2026
PHP 8.6 support #601
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@GrahamCampbell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.