GeezerVison is showing github.com — Fix PHP warnings when building an incomplete CASE expression · phpmyadmin/sql-parser@b47e27b
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/Components/CaseExpression.php +3-3Lines changed: 3 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -33,21 +33,21 @@ class CaseExpression extends Component |
33 | 33 | * |
34 | 34 | * @var array |
35 | 35 | */ |
36 | | - public $conditions; |
| 36 | + public $conditions = []; |
37 | 37 |
|
38 | 38 | /** |
39 | 39 | * The results matching with the WHEN clauses. |
40 | 40 | * |
41 | 41 | * @var array |
42 | 42 | */ |
43 | | - public $results; |
| 43 | + public $results = []; |
44 | 44 |
|
45 | 45 | /** |
46 | 46 | * The values to be compared against. |
47 | 47 | * |
48 | 48 | * @var array |
49 | 49 | */ |
50 | | - public $compare_values; |
| 50 | + public $compare_values = []; |
51 | 51 |
|
52 | 52 | /** |
53 | 53 | * The result in ELSE section of expr. |
|
Collapse file
Copy file name to clipboardExpand all lines: tests/Components/CaseExpressionTest.php +6Lines changed: 6 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -118,4 +118,10 @@ public function testParseBuild8() |
118 | 118 | 'CASE WHEN 1=1 THEN "Some" WHEN 1=2 THEN "SomeOther" END AS `foo`' |
119 | 119 | ); |
120 | 120 | } |
| 121 | + |
| 122 | + public function testBuildWithIncompleteCaseExpression() |
| 123 | + { |
| 124 | + $incomplete_case_expression_component = new CaseExpression(); |
| 125 | + $this->assertEquals('CASE END', CaseExpression::build($incomplete_case_expression_component)); |
| 126 | + } |
121 | 127 | } |
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCase1.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCase2.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCase3.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCase4.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCaseAlias1.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCaseAlias2.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCaseAlias5.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.
Collapse file
Copy file name to clipboardExpand all lines: tests/data/parser/parseSelectCaseAlias6.out +1-1Lines changed: 1 addition & 1 deletion Large diffs are not rendered by default.