GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix tyephint on `SelectStatement::$expr` by niconoe- · Pull Request #583 · phpmyadmin/sql-parser

Conversation

@niconoe-

@niconoe- niconoe- commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

If you try to parse a query like

SELECT CASE WHEN `VALUE` = 1 THEN `COLUMN_ONE` END;

you will see that SelectStatement::$expr is actually containing a CaseExpression and not an Expression.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@niconoe-
Fix tyephint on SelectStatement::$expr.
3975930
MauricioFauth
MauricioFauth approved these changes Sep 13, 2024
View reviewed changes
@MauricioFauth
MauricioFauth merged commit f46b2c8 into phpmyadmin:5.10.x Sep 19, 2024
@MauricioFauth MauricioFauth self-assigned this Sep 19, 2024
@MauricioFauth MauricioFauth added this to the 5.10.1 milestone Sep 19, 2024
@niconoe-
niconoe- deleted the fix/typehint-select-expr branch September 20, 2024 08:15
@niconoe- niconoe- mentioned this pull request Sep 20, 2024
Incorrect type in SelectStatement::$expr when query has CASE-clause in selected fields #552
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauricioFauth MauricioFauth MauricioFauth approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@MauricioFauth MauricioFauth

Labels

None yet

Projects

None yet

Milestone

5.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@niconoe- @MauricioFauth
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.