GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ignore E2E test data for Git export by MauricioFauth · Pull Request #622 · phpmyadmin/sql-parser

Conversation

@MauricioFauth

@MauricioFauth MauricioFauth commented Apr 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Fixes The end-to-end tests should be ignored from Git export #621

We can work on master branch a way of extracting these tests and run them separately.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
williamdes and natewiebe13 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@MauricioFauth
Ignore E2E test data for Git export
7a23cad 
- Fixes phpmyadmin#621

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth
MauricioFauth requested a review from williamdes April 1, 2025 17:26
williamdes
williamdes reviewed Apr 1, 2025
View reviewed changes
Comment thread tests/TestCase.php
*/
public function getData(string $name): array
{
if (! file_exists('tests/data/' . $name . '.out')) {

@williamdes williamdes Apr 1, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be too risky for new tests to have missing data
can you check in setUp() if the folder exists?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@MauricioFauth MauricioFauth Apr 1, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There some test classes that have more than e2e tests, so skipping in setUp() will also skip valid tests that do not depend on that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@MauricioFauth MauricioFauth Apr 1, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best option is to refactor the tests, but I don't know how much refactoring is needed. I already attempted changing those tests (#598), but I'm yet to find a good solution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@williamdes williamdes Apr 1, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, can you turn the phpunit to error when there is skipped tests on the CI?
I think that will be a good safety measure
Or use incomplete instead of skipped

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MauricioFauth @williamdes
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.