GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix lex number at start of name followed by _ or $ by MoonE · Pull Request #632 · phpmyadmin/sql-parser

Conversation

@MoonE

@MoonE MoonE commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Fixes #607

_ and $ are also non-separator characters.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MoonE
Add a test for name starting with number followed by _
30b5c95
Signed-off-by: Maximilian Krög <[email protected]>
@MoonE
MoonE changed the base branch from master to 5.11.x September 5, 2025 21:39
@MoonE
Fix lexing name starting with numner
b61f7af
Only [a-zA-z] were considered a separator to the next token, missing were [__git_main].

Signed-off-by: Maximilian Krög <[email protected]>
@MoonE
MoonE force-pushed the fix-lex-number-at-start-of-name branch from bbb4fa3 to b61f7af Compare September 5, 2025 21:40
williamdes
williamdes approved these changes Sep 8, 2025
View reviewed changes

@williamdes williamdes left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the diff looks okay and current tests are happy
Thanks for adding a new test !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@williamdes
williamdes requested a review from MauricioFauth September 8, 2025 16:52
@williamdes williamdes self-assigned this Oct 13, 2026
@williamdes
williamdes removed the request for review from MauricioFauth October 13, 2026 10:50
@williamdes williamdes added this to the 5.11.3 milestone Oct 13, 2026
@williamdes
williamdes merged commit e08e9d2 into phpmyadmin:5.11.x Oct 13, 2026
@MoonE
MoonE deleted the fix-lex-number-at-start-of-name branch October 13, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@williamdes williamdes

Labels

None yet

Projects

None yet

Milestone

5.11.3

Development

Successfully merging this pull request may close these issues.

SQL Editor unexpected token with numeric db suffix and table name prefix

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MoonE @williamdes
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.