GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix #641 - Add VECTOR data type and VECTOR INDEX support by predictor2718 · Pull Request #651 · phpmyadmin/sql-parser

Conversation

@predictor2718

@predictor2718 predictor2718 commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added VECTOR as a reserved keyword with FLAG_KEYWORD_DATA_TYPE in MySQL 9.0-9.3 contexts
  • Added VECTOR as a reserved keyword with FLAG_KEYWORD_DATA_TYPE in MariaDB 11.7-12.1 contexts
  • Added VECTOR INDEX and VECTOR KEY as composed key keywords in all affected contexts
  • Previously VECTOR(5) triggered "Unrecognized data type" and VECTOR INDEX was parsed as a column definition

Fixes #641.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@predictor2718
Fix phpmyadmin#641 - Add VECTOR data type and VECTOR INDEX support
e35222a
Signed-off-by: Nicolai Ehrhardt <[email protected]>
@codecov

codecov Bot commented Apr 13, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (4c45eac) to head (221efc3).

Additional details and impacted files
@@            Coverage Diff            @@
##             5.11.x     #651   +/-   ##
=========================================
  Coverage     96.92%   96.92%           
  Complexity     2316     2316           
=========================================
  Files            71       71           
  Lines          5110     5110           
=========================================
  Hits           4953     4953           
  Misses          157      157           
Flag Coverage Δ
unit-7.2-ubuntu-latest 96.92% <ø> (ø)
unit-7.3-ubuntu-latest 96.91% <ø> (ø)
unit-7.4-ubuntu-latest 96.89% <ø> (ø)
unit-8.0-ubuntu-latest 96.91% <ø> (ø)
unit-8.1-ubuntu-latest 96.91% <ø> (ø)
unit-8.2-ubuntu-latest 96.87% <ø> (ø)
unit-8.3-ubuntu-latest 96.87% <ø> (ø)
unit-8.4-ubuntu-latest 96.87% <ø> (ø)
unit-8.5-ubuntu-latest 96.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@predictor2718
Update PHPStan baseline for test assertions
221efc3
Signed-off-by: Nicolai Ehrhardt <[email protected]>
@xmaks82

xmaks82 commented Oct 23, 2026

Copy link
Copy Markdown

MariaDB also prints the vector index options in SHOW CREATE TABLE (11.8):

VECTOR KEY `v` (`v`) `M`='8' `DISTANCE`='cosine'

With this branch, VECTOR INDEX (v) M=8 DISTANCE=cosine still gives A comma or a closing bracket was expected. (near "M"), and the index options are dropped. Adding them to Key::$KEY_OPTIONS fixes the unquoted form (I used separate order numbers so they do not share a slot with VISIBLE/INVISIBLE):

'M' => [7, 'var='],
'DISTANCE' => [8, 'var='],

The quoted form also needs backquoted option names to be accepted, see #644.

Docs: https://mariadb.com/docs/server/reference/sql-structure/vectors/create-table-with-vectors

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xmaks82 xmaks82 mentioned this pull request Oct 23, 2026
Fix parsing of backtick-enclosed table options #644
Open
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@predictor2718 @xmaks82
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.