GeezerVison

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.30%. Comparing base (f440917) to head (70b388b).

@@            Coverage Diff            @@
##             master     #654   +/-   ##
=========================================
  Coverage     96.30%   96.30%           
- Complexity     2254     2255    +1     
=========================================
  Files            90       90           
  Lines          4982     4982           
=========================================
  Hits           4798     4798           
  Misses          184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also, please add test cases

Also, please add test cases

Here's the most succinct test case I can provide:

SELECT
    CASE
        WHEN table_a.column_a = 'FOO'
        THEN table_b.column_a
        ELSE table_b.column_b
END AS foo

Output before change:

SELECT
    CASE foo
    ELSE table_b.column_b AS `END`
END

Output after change:

SELECT
    CASE WHEN table_a.column_a = 'FOO'
    THEN table_b.column_a
    ELSE table_b.column_b
END AS `foo`

If this gets merged into 5.11.x, would it be put into 6.0.0 as well? That is the version that we are currently running and can't really downpatch.

@williamdes Is there anything more you need from me on this?