GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix CTE view parsing across statement delimiters by oiahoon · Pull Request #660 · phpmyadmin/sql-parser

Conversation

@oiahoon

@oiahoon oiahoon commented Jul 12, 2026

Copy link
Copy Markdown

Summary

Stop a CTE view's nested parser at the delimiter that separates it from the next SQL statement. Without this boundary, consecutive unparenthesized CREATE VIEW ... AS WITH ... statements are parsed as one view and the second statement is appended to the first view's build output.

Fixes #639.

Changes

  • Bound the CTE expression and ON DUPLICATE KEY UPDATE scans to the current statement.
  • Add a focused regression asserting that two consecutive CTE views remain independent.
  • Regenerate the existing parseCreateViewAsWithAs parser fixture so it records two top-level statements. The fixture input itself is unchanged.

Testing

  • Focused CreateStatementTest and WithStatementTest: 86 tests, 1,506 assertions
  • Full non-CLI suite: 977 tests, 10,167 assertions
  • Changed-file PHPCS and PHPStan
  • Full Psalm
  • composer validate --strict --no-check-publish
  • PHP syntax checks and git diff --check
  • Deterministic parser fixture regeneration

The complete local suite has six CLI-only failures because its command strings do not quote this checkout path, which contains a space. The untouched master baseline reproduces the same six failures; all 977 non-CLI tests pass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@oiahoon
Stop CTE views at statement delimiters
d12afde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Views with CTEs parsed incorrectly

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@oiahoon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.