GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix parsing of STORAGE ENGINE in partition definitions by M393 · Pull Request #685 · phpmyadmin/sql-parser

Conversation

@M393

@M393 M393 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

PartitionDefinition already lists STORAGE ENGINE as an option, but the lexer did not compose it into a single keyword. So STORAGE was taken as a new partition name, building e.g. PARTITION ENGINE, PARTITION InnoDB.

Add STORAGE ENGINE to the compound keywords and regenerate the contexts.

STORAGE ENGINE is only valid for partitions (and tablespaces), not as a table option, in all MySQL and MariaDB versions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
liviuconcioiu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@M393 @claude
Fix parsing of STORAGE ENGINE in partition definitions
0b553fb 
PartitionDefinition already lists STORAGE ENGINE as an option, but the
lexer did not compose it into a single keyword. So STORAGE was taken as
a new partition name, building e.g. `PARTITION ENGINE, PARTITION InnoDB`.

Add STORAGE ENGINE to the compound keywords and regenerate the contexts.

STORAGE ENGINE is only valid for partitions (and tablespaces), not as a
table option, in all MySQL and MariaDB versions.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Signed-off-by: Maximilian Krög <[email protected]>
@codecov

codecov Bot commented Oct 27, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (18d63ad) to head (0b553fb).

Additional details and impacted files 
@@             Coverage Diff              @@
##             5.11.x     #685      +/-   ##
============================================
- Coverage     96.51%   96.50%   -0.01%     
+ Complexity     2352     2341      -11     
============================================
  Files            71       71              
  Lines          5187     5179       -8     
============================================
- Hits           5006     4998       -8     
  Misses          181      181
Flag Coverage Δ
unit-7.2-ubuntu-latest ?
unit-7.3-ubuntu-latest 96.49% <ø> (ø)
unit-7.4-ubuntu-latest ?
unit-8.0-ubuntu-latest 96.49% <ø> (ø)
unit-8.1-ubuntu-latest 96.47% <ø> (ø)
unit-8.2-ubuntu-latest ?
unit-8.3-ubuntu-latest 96.43% <ø> (ø)
unit-8.4-ubuntu-latest ?
unit-8.5-ubuntu-latest 96.43% <ø> (ø)
unit-8.6-ubuntu-latest 96.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@M393
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.