GeezerVison is showing github.com — Fix quoted table options and add missing options in CREATE TABLE statement by M393 · Pull Request #686 · phpmyadmin/sql-parser
Conversation
M393
commented
Oct 27, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Most table options were not covered by any test.
The data provider replaces testBuilderCompressed and checks that each
option is rebuilt and does not consume the tokens following it.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Signed-off-by: Maximilian Krög <[email protected]>
Options not in the list were dropped when building the statement,
together with all the options following them.
Added options documented by MySQL and MariaDB:
PAGE_CHECKSUM, TRANSACTIONAL, ENCRYPTED, ENCRYPTION_KEY_ID, ENCRYPTION,
COMPRESSION, STATS_AUTO_RECALC, STATS_PERSISTENT, STATS_SAMPLE_PAGES,
AUTOEXTEND_SIZE, IETF_QUOTES, SEQUENCE, ENGINE_ATTRIBUTE,
SECONDARY_ENGINE_ATTRIBUTE and ADAPTIVE_HASH_INDEX.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Signed-off-by: Maximilian Krög <[email protected]>
MariaDB quotes engine-defined table options in SHOW CREATE TABLE, e.g.
`PAGE_COMPRESSED`='ON'. These were not recognized, so they were dropped
together with all the options following them. phpMyAdmin rebuilds the
statement when exporting the table structure, losing these options.
Quoted names are only accepted where the options array enables it with
`_ALLOW_QUOTED`, so quoted identifiers like SELECT `DISTINCT` are not
mistaken for options.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Signed-off-by: Maximilian Krög <[email protected]>
codecov
Bot
commented
Oct 27, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (18d63ad) to head (45312e6).
Additional details and impacted files
@@ Coverage Diff @@
## 5.11.x #686 +/- ##
============================================
- Coverage 96.51% 96.50% -0.01%
+ Complexity 2352 2345 -7
============================================
Files 71 71
Lines 5187 5184 -3
============================================
- Hits 5006 5003 -3
Misses 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
|
liviuconcioiu reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.