GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix keys mixing columns and functional key parts by Niksac · Pull Request #687 · phpmyadmin/sql-parser

Conversation

@Niksac

@Niksac Niksac commented Nov 2, 2026

Copy link
Copy Markdown

Fixes #640
Also fixes phpmyadmin/phpmyadmin#18236

A key mixing columns and functional key parts lost its expressions
when built, e.g. UNIQUE KEY u (a,(IFNULL(c,'x'))) was exported as
(a,(x)). Each functional key part is now parsed as its own entry in
Key::$columns (with optional ASC/DESC). Keys made of expressions
only still use Key::$expr, so existing behaviour stays the same.

Disclosure: most of the patch was written by Claude, then reviewed and tested by me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Niksac
Fix keys mixing columns and functional key parts
4b32531 
After a column, a functional key part like (IFNULL(c,'x')) was
read as a column length and its expression was lost when building
the statement, so phpMyAdmin exported a broken index.

Each functional key part is now its own entry in Key::$columns.
Keys made of expressions only still use Key::$expr.

Fixes phpmyadmin#640

Signed-off-by: nik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Niksac
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.